Skip to content

Fix paywall Add payment card CTA navigation race in restricted action - #91509

Merged
neil-marcellini merged 13 commits into
Expensify:mainfrom
neerajbachani:fix/89718-paywall-add-card-redirect
Jun 10, 2026
Merged

neil-marcellini merged 13 commits into
Expensify:mainfrom
neerajbachani:fix/89718-paywall-add-card-redirect

Conversation

@neerajbachani

@neerajbachani neerajbachani commented May 23, 2026 •

Copy link
Copy Markdown
Contributor

Use dismissModal with afterTransition for web/native owner CTA to avoid modal-stack race, and add regression tests for web and native routes.

Explanation of Change

The workspace owner paywall CTA was calling Navigation.closeRHPFlow() and immediately calling Navigation.navigate(...). That dispatches two navigation actions in the same tick while the RHP/modal stack is still transitioning, which can drop the follow-up navigation and make the button appear to do nothing.

This PR keeps the existing UX unchanged (web still shows Add payment card and routes to the add-card screen; native still shows Go to Subscription and routes to subscription settings). It only fixes navigation sequencing by using Navigation.dismissModal({ afterTransition: () => Navigation.navigate(...) }) in both platform handlers, and adds unit tests to lock in web/native behavior.

Fixed Issues

$ #89718
PROPOSAL: #89718 (comment)

Tests

  1. Sign up / use a workspace owner account with billing restriction (amount owed + grace period ended).
  2. Open FAB → Create expense → Manual expense → enter amount → Next.
  3. On Choose recipient, select the restricted workspace chat and open the paywall modal.
  4. Click Add payment card (web).
  5. Confirm navigation to subscription with add-card flow occurs reliably (no “stuck” modal with no navigation).
  • Verify that no errors appear in the JS console

Offline tests

  1. Reproduce the paywall state (billing NVPs as in issue repro).
  2. Disable network.
  3. FAB → Create expense → choose restricted workspace → open paywall.
  4. Tap Add payment card (web) / Go to Subscription (native).
  5. Confirm navigation still occurs to the expected billing screen (client-side navigation).

QA Steps

  1. Go to https://staging.new.expensify.com/
  2. Use a workspace owner in billing-restricted state (or set NVPs per issue repro).
  3. Go offline (disable network)
  4. FAB → Create Expense → Manual expense → amount → Next.
  5. Select workspace chat to open restricted paywall.
  6. Click Add payment card (web).
  7. Verify user is redirected into billing flow subscription with add-card paywall on top.
  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
android-native.mp4
Android: mWeb Chrome
lv_0_20260601170213.mp4
iOS: Native
iOS: mWeb Safari
lv_0_20260601175543.mp4
MacOS: Chrome / Safari
lv_0_20260525004735.mp4

Use dismissModal with afterTransition for web/native owner CTA to avoid modal-stack race, and add regression tests for web and native routes.
@neerajbachani
neerajbachani requested review from a team as code owners May 23, 2026 13:42
@melvin-bot
melvin-bot Bot requested review from heyjennahay and thelullabyy and removed request for a team May 23, 2026 13:42
@melvin-bot

melvin-bot Bot commented May 23, 2026

Copy link
Copy Markdown

@thelullabyy Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e9aa78e5b2

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment on lines +24 to +25
Navigation.dismissModal({
afterTransition: () => Navigation.navigate(ROUTES.SETTINGS_SUBSCRIPTION_ADD_PAYMENT_CARD),

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve underlying RHP flow before navigating to billing

Switching from Navigation.closeRHPFlow() to Navigation.dismissModal() changes behavior from “pop only the top RHP flow” to “pop the entire RIGHT_MODAL navigator,” so users who open this paywall from a multi-step modal flow (e.g., expense creation) lose their in-progress stack when they tap the CTA. closeRHPFlow was designed to keep prior RHP routes when more than one exists, but dismissModal always dismisses the modal route itself, so back navigation can no longer return to the interrupted flow.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, this is better, Preserves underlying multi-step RHP flow semantics ( closeRHPFlow ) , Still avoids the navigation race ( waitForTransition ), code updated.

Use closeRHPFlow with waitForTransition navigation for web/native owner CTAs to avoid modal-stack race without dismissing the full modal stack, and add regression tests.
@neerajbachani

Copy link
Copy Markdown
Contributor Author

okay @codex review again, make no mistakes

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Chef's kiss.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

@thelullabyy

thelullabyy commented May 24, 2026 •

Copy link
Copy Markdown
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Android: mWeb Chrome
iOS: HybridApp
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2026-06-09.at.16.36.23.mov

const expensifyIcons = useMemoizedLazyExpensifyIcons(['Unlock']);

const addPaymentCard = () => {
const addPaymentCard = useCallback(() => {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to wrap this func inside useCallback? I believe it will be handled by react compiler, we should avoid using useCallback and useMemo

@thelullabyy

Copy link
Copy Markdown
Contributor

It looks like the solution you are using here doesn't match with your proposal, any reason behind? @neerajbachani

Drop manual memoization from the restricted action CTA handlers while keeping the existing closeRHPFlow plus waitForTransition navigation behavior unchanged.
@neerajbachani

Copy link
Copy Markdown
Contributor Author

@thelullabyy

Yes the current implementation is slightly different from the original proposal. I initially implemented the accepted proposal exactly with dismissModal({afterTransition}), but during PR review Codex pointed out that dismissModal() dismisses the full RHP stack, which could drop the interrupted multi-step flow (for example, the underlying expense creation flow).

To avoid that regression, I updated the implementation to:

  • keep Navigation.closeRHPFlow() so we preserve the underlying RHP flow semantics
  • use Navigation.navigate(..., {waitForTransition: true}) so we still avoid the same navigation race described in the proposal

So the root cause/fix direction is the same (serialize navigation instead of doing close + navigate in the same tick), but the implementation was refined during review to preserve existing RHP behavior.

Also agreed on useCallback here, it wasn’t necessary. I removed it in the latest update.

@codecov

codecov Bot commented May 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...Workspace/WorkspaceOwnerRestrictedAction/index.tsx 100.00% <ø> (+100.00%) ⬆️
... and 8 files with indirect coverage changes

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@thelullabyy friendly bump, thanks

@thelullabyy

thelullabyy commented May 29, 2026 •

Copy link
Copy Markdown
Contributor

@neerajbachani Missing recordings for android, ios, android web, ios web. Please add them

@thelullabyy

Copy link
Copy Markdown
Contributor

Did you re-test the latest changes? I think it doesn't work

Screen.Recording.2026-05-29.at.11.28.56.mov

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@thelullabyy Thanks for re-testing

The intermediate change (closeRHPFlow + waitForTransition) tried to preserve the underlying expense RHP stack, but that left billing navigation layered inside the modal stack and did not match the expected foreground redirect.

codex concern was correct but not for this repro, i matters when the user should only close the top screen and return to the previous step in the same modal (e.g. pop paywall, stay in create-expense).

but this issue is not our case.

so I've reverted to the accepted approach: dismissModal({ afterTransition: () => navigate(...) }), which intentionally dismisses the full modal flow when the user leaves to add a payment card, then navigates once the transition completes. Platform routes are unchanged (web → add-card, native → subscription).

Revert closeRHPFlow plus waitForTransition so billing navigation runs after the full modal dismisses, matching the accepted proposal and fixing layered RHP navigation in the expense paywall flow.
@thelullabyy

Copy link
Copy Markdown
Contributor

@neerajbachani The recording for android/ios native and android mWeb are invalid. You have to use simulator/real device to test it. I see you are testing on windows' chrome. Let's update them. Besides, please note that testing on iOS and android are required steps in order to get the PR reviewed & merged

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@thelullabyy

For Android mWeb I used USB debugging: you can only see the Onyx injection part only show cursor on desktop because that’s where the console runs for the issue repro. After injection, the app flow in the video is on my real device.

lemme know if this works or I'll re-record?

Use dismissModal with afterTransition for web/native owner CTA to avoid modal-stack race, and add regression tests for web and native routes.
Use closeRHPFlow with waitForTransition navigation for web/native owner CTAs to avoid modal-stack race without dismissing the full modal stack, and add regression tests.
Drop manual memoization from the restricted action CTA handlers while keeping the existing closeRHPFlow plus waitForTransition navigation behavior unchanged.
Revert closeRHPFlow plus waitForTransition so billing navigation runs after the full modal dismisses, matching the accepted proposal and fixing layered RHP navigation in the expense paywall flow.
@thelullabyy

Copy link
Copy Markdown
Contributor

@neerajbachani I see. Please re-record the android and ios native then

@neerajbachani

Copy link
Copy Markdown
Contributor Author

@thelullabyy I've added the native platform recordings

delay happens because while reproducing on native, I initially thought something was wrong because the add payment card flow doesn't open and there's no "Add payment card" button on the Subscription page. I checked staging/live with the same account and saw the same behavior, then traced it in the codebase.

image

On native we intentionally route the paywall CTA to the Subscription page (Go to Subscription), not the add-card screen. Subscription payment management is reduced on mobile: CardSectionDataEmpty native shows a static "No payment card added" state (no button), and PaymentCard/index.native.tsx is a not-found stub. Web still has the full add-card flow, which matches what I see on web/staging.

So for this issue, native QA is: paywall → foreground Subscription page (not add-card parity with web). lemme know your thoughts about this being expected or need follow up pr?

}, [activeRoute]);
const goToSubscription = () => {
const activeRoute = Navigation.getActiveRoute();
Navigation.dismissModal({

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@neerajbachani why do we need this change?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thelullabyy I initially kept the native change because I thought the same paywall navigation race could happen on native too.

After repeated native testing , Go to Subscription already navigates correctly to the foreground Subscription page with the existing main native handler, so native change is not needed for this issue.

I reverted native in 18ea3ec and the latest branch keeps native unchanged (web-only fix + tests). Final PR diff only changes web index.tsx and unit tests.

@thelullabyy

Copy link
Copy Markdown
Contributor

@neerajbachani The evidence for ios native looks not real. Do you have device to test it? Please make sure that you are able and test on native device as it is required when contributing to the project

@Expensify/product Could you please confirm this behavior?

  • On native app, we show "Go to Subscription" CTA --> Go to Subscription page

  • On native web, we show "Add payment card" CTA --> Go to Subscription page and then open Add payment card page

Should we fix the native app to match with native web behavior or it is expected?

Native Web:

-2.mov

Native App:

Screen.Recording.2026-06-04.at.02.16.24.mov

@shawnborton

Copy link
Copy Markdown
Contributor

That is expected behavior AFAIK.

@thelullabyy

Copy link
Copy Markdown
Contributor

Thanks for confirmation @shawnborton

All yours @neerajbachani then #91509 (comment) #91509 (comment)

Please resolved these 2 issues ^ so we are good to go

@trjExpensify

Copy link
Copy Markdown
Contributor

Yep, agreed with @shawnborton it's expected due to Apple/Google restrictions. 👍

Keep web dismissModal afterTransition fix only. Native was re-tested on
Android without navigation changes and already redirects correctly, so
restore main closeRHPFlow behavior and update tests accordingly.
@thelullabyy

Copy link
Copy Markdown
Contributor

@neerajbachani Bump on this, could you please priority this task, I think we are getting slowly on this

Resolve conflicts by keeping local web-only dismissModal fix and unchanged
native closeRHPFlow handler after device validation.
@neerajbachani

Copy link
Copy Markdown
Contributor Author

All yours @neerajbachani then #91509 (comment) #91509 (comment)

@thelullabyy aight, addressed both points:

  1. Native change rationale - replied here: Fix paywall Add payment card CTA navigation race in restricted action #91509 (comment)
    I reverted native after repeated Android testing; existing native handler already redirects to Subscription correctly, so PR is now web-only (final diff: web handler + tests).

  2. iOS native recording my earlier iOS clip was from simulator and may look unreliable due asset/build loading issues on that setup. I’ve validated native behavior on real Android, and since native code is unchanged vs main, iOS behavior should be the same.

If iOS device recording is still required for merge, please let me know, I’ll add a real-device recording as well

Updated branch is pushed and ready for re-review. Thanks!

@thelullabyy

Copy link
Copy Markdown
Contributor

On my plate today

@thelullabyy thelullabyy left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@melvin-bot
melvin-bot Bot requested a review from neil-marcellini June 9, 2026 21:47
@neil-marcellini
neil-marcellini merged commit 69348af into Expensify:main Jun 10, 2026
34 of 35 checks passed
@github-actions

Copy link
Copy Markdown
Contributor

🚧 @neil-marcellini has triggered a test Expensify/App build. You can view the workflow run here.

mukhrr pushed a commit to mukhrr/App that referenced this pull request Jun 10, 2026
Replace the unsafe `as` cast with proper type narrowing so post-merge
preDeploy lint passes after PR Expensify#91509.

Co-authored-by: Cursor <cursoragent@cursor.com>
@OSBotify OSBotify mentioned this pull request Jun 10, 2026
72 tasks done
@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by https://github.com/neil-marcellini in version: 9.4.5-0 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Bundle Size Analysis (Sentry):

@MelvinBot

Copy link
Copy Markdown
Contributor

🤖 Help site review: No documentation changes required.

This PR is an internal navigation-sequencing bug fix and does not change any user-facing behavior, feature, or copy.

Why no docs changes are needed
  • The only product change is in WorkspaceOwnerRestrictedAction/index.tsx, swapping Navigation.closeRHPFlow() + Navigation.navigate(...) for Navigation.dismissModal({ afterTransition: () => Navigation.navigate(...) }) to avoid a modal-stack race.
  • The PR explicitly preserves existing UX: web still shows Add payment card and routes to the add-card screen; native still shows Go to Subscription and routes to subscription settings.
  • The remaining change is a new unit test file — no shippable behavior.
  • No feature names, tab names, settings labels, button labels, or workflows changed, so nothing under App/docs/articles needs updating.

Because there are no behavioral or copy changes, no draft help site PR was created.

@neerajbachani, please review the linked help site PR and confirm it reflects the current behavior. Then mark the linked help site PR Ready for review

(Note: no help site PR was created because this change has no documentation impact. If you believe a docs update is warranted, let me know what behavior to document and I'll draft one.)

@OSBotify

Copy link
Copy Markdown
Contributor

🚀 Deployed to production by https://github.com/Julesssss in version: 9.4.5-6 🚀

platform result
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants